Skip to content

Commit

Permalink
doc: adding minor clarification to CONTRIBUTING.MD (#79)
Browse files Browse the repository at this point in the history
Thanks for contributing!
  • Loading branch information
rrafols authored and Jesús Seijas committed Oct 5, 2018
1 parent febff51 commit 340eb54
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,13 @@
Should you run into issues with the project, please don't hesitate to let us know by
[filing an issue](https://github.com/axa-group/nlp.js/issues/new).

Pull requests containing only failing tests demonstrating the issue are welcomed
and this also helps ensure that your issue won't regress in the future once it's fixed.
Pull requests containing only failing tests demonstrating an issue are also welcomed. Having these tests will help avoiding future regressions of this specific issue once it's fixed.

## Pull Requests

We accept [pull requests](https://github.com/axa-group/nlp.js/pull/new/master)!

Generally we like to see pull requests that
Generally we like to see pull requests that:

- Maintain the existing code style
- Are focused on a single change (i.e. avoid large refactoring or style adjustments in untouched code if not the primary goal of the pull request)
Expand All @@ -32,4 +31,4 @@ From the root directory, run the tests.

```shell
npm test
```
```

0 comments on commit 340eb54

Please sign in to comment.