fix(alarms): fix data mapping from input property values #3028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Bugfix for useAlarms AlarmData mapping. The internal alarms data in useInputPropertyTimeSeriesData is only being modified when the property changes. This ensures we don't call time series data every time any irrelevant property changes in the alarms model, but it also means the internal model may not be up to date. To fix this, we only call useTimeSeriesData with the internal model, so that it is not overly reactive, but map the output with the up to date models.
Legal
This project is available under the Apache 2.0 License.