Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(alarms): clean up gauge and KPI loading states #3026

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

corteggiano
Copy link
Contributor

@corteggiano corteggiano commented Oct 2, 2024

Overview

KPI - value loading

Screenshot 2024-10-03 at 08 34 04 Screenshot 2024-10-03 at 08 33 56

KPI - alarm and value loading

Screenshot 2024-10-03 at 08 32 36

KPI - alarm loading

Screenshot 2024-10-03 at 07 59 28

Gauge - alarm loading

Screenshot 2024-10-03 at 07 52 42

Gauge - alarm and value loading

Screenshot 2024-10-03 at 07 52 05

Gauge - value loading alarm error

Screenshot 2024-10-03 at 07 50 52

Legal

This project is available under the Apache 2.0 License.

@corteggiano corteggiano marked this pull request as ready for review October 2, 2024 18:20
@corteggiano corteggiano marked this pull request as draft October 2, 2024 19:00
@corteggiano corteggiano changed the title fix(alarm): dont hide value if alarm is loading chore(alarms): clean up gauge and KPI states Oct 3, 2024
@corteggiano corteggiano changed the title chore(alarms): clean up gauge and KPI states chore(alarms): clean up gauge and KPI loading states Oct 3, 2024
@corteggiano corteggiano marked this pull request as ready for review October 3, 2024 16:00
@corteggiano corteggiano merged commit d3f1f04 into rc Oct 3, 2024
20 checks passed
@corteggiano corteggiano deleted the alarms-show-data branch October 3, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants