feat(bar chart alarms): add alarms to bar chart #3003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corteggiano
force-pushed
the
alarms-bar-status
branch
3 times, most recently
from
0111d39
to
3d4be9a
Compare
hwandersman
reviewed
Sep 25, 2024
packages/react-components/src/components/bar-chart/barChart.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/src/components/bar-chart/barChart.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/src/components/bar-chart/barChart.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/src/utils/transformAlarmThresholdToSynchroChartsThreshold.ts
Outdated
Show resolved
Hide resolved
packages/react-components/src/utils/transformAlarmThresholdToSynchroChartsThreshold.ts
Outdated
Show resolved
Hide resolved
hwandersman
reviewed
Sep 25, 2024
packages/react-components/src/components/bar-chart/barChart.tsx
Outdated
Show resolved
Hide resolved
corteggiano
force-pushed
the
alarms-bar-status
branch
from
3d4be9a
to
8056660
Compare
hwandersman
reviewed
Sep 25, 2024
packages/react-components/src/utils/transformAlarmsToThreshold.ts
Outdated
Show resolved
Hide resolved
hwandersman
previously approved these changes
Sep 25, 2024
corteggiano
force-pushed
the
alarms-bar-status
branch
from
8056660
to
0e40c7c
Compare
ssjagad
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add alarms to the bar chart by using the synchr-charts threshold props
barChartAlarms2.mov
custom alarm only:
demo alarm only:
zoomed in so label isnt hidden:
Tests:
Legal
This project is available under the Apache 2.0 License.