fix(scene composer): Color picker bug fixes #1798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divya-sea
force-pushed
the
color-bugs
branch
2 times, most recently
from
f6b5a2c
to
f9f0f11
Compare
haweston
reviewed
Aug 15, 2023
.../scene-composer/src/components/panels/scene-components/tag-style/ColorPicker/ColorPicker.tsx
Show resolved
Hide resolved
haweston
reviewed
Aug 15, 2023
.../scene-composer/src/components/panels/scene-components/tag-style/ColorPicker/ColorPicker.tsx
Show resolved
Hide resolved
haweston
approved these changes
Aug 16, 2023
This changes contain rules updated with color picker, removed unwanted effects from color picker sufficient unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Provide an explanation of what the change is
Verifying Changes
Scene Composer
For
scene-composerpackage changes specifically, you can preview the component in the published storybook artifact. To do this, wait for thePublish Storybookaction to complete below.To run the storybook build locally, you need a local static web server:
Then open the website http://localhost:8080 to run the doc site.
Legal
This project is available under the Apache 2.0 License.