Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Load manager): fixed the downloaded bytes onProgress call #1796

Merged
merged 2 commits into from
Aug 18, 2023

Conversation

divya-sea
Copy link
Contributor

@divya-sea divya-sea commented Aug 14, 2023

Overview

This change contains fix for showing asset bytes downloading status. Initially we were hardcoding it to 0. Now are calculating based on downloaded and already loaded bytes.

Verifying Changes

Scene Composer

For scene-composer package changes specifically, you can preview the component in the published storybook artifact. To do this, wait for the Publish Storybook action to complete below.

  • Click on the workflow details
  • Select the Summary item on the left
  • Download the zip file

To run the storybook build locally, you need a local static web server:

npm install -g httpserver
cd <Extracted Zip Directory>
httpserver

Then open the website http://localhost:8080 to run the doc site.

Legal

This project is available under the Apache 2.0 License.

@divya-sea divya-sea merged commit f08a441 into release-3.x Aug 18, 2023
7 checks passed
@divya-sea divya-sea deleted the loader-fix branch August 18, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants