fix(scene composer): fix overlay arrow clickable space #1780
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
There is an extra invisible space below the overlay and a section on the overlay (the arrow) where if user clicks tag is not getting selected. Updated the overlay arrow CSS to keep the same visuals but the entire area clickable.
Verifying Changes
Create a tag. Add an overlay to the tag using the node inspector in the Scene Composer.
Click on the tag to show the overlay panel. Click on the tag below the panel, but to the right or left of the arrow, to deselect it. Click on the arrow at the bottom of the panel to reselect the tag. Should be able to click anywhere on the tag to select/deselect, and anywhere on the panel including the arrow to reselect the tag.
Screen.Recording.-.Click.Tag.With.Overlay.Panel.mov
Scene Composer
For
scene-composer
package changes specifically, you can preview the component in the published storybook artifact. To do this, wait for thePublish Storybook
action to complete below.To run the storybook build locally, you need a local static web server:
Then open the website http://localhost:8080 to run the doc site.
Legal
This project is available under the Apache 2.0 License.