Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(data overlay): add onWidgetClick and onSelectionChange event support to release 3.x #1776

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

haweston
Copy link
Contributor

@haweston haweston commented Aug 7, 2023

Overview

Click an overlay doesn't have data binding information in the onSelectionChange event fired from the SceneViewer and the onWidgetClick event is fired at all.

Ports change to release 3.x as well

Verifying Changes

Create scene with dataoverlay that has 2+ data bindings added to it.

Connect to scene in SceneViewer mode on storybook

Click the overlay widget

verify that the storybook actions log both selection and widget change events with databindings that look like this for array of 2 data bindings:

258239376-93f1474c-60ca-4387-859a-a57b52abe0e2

Scene Composer

For scene-composer package changes specifically, you can preview the component in the published storybook artifact. To do this, wait for the Publish Storybook action to complete below.

  • Click on the workflow details
  • Select the Summary item on the left
  • Download the zip file

To run the storybook build locally, you need a local static web server:

npm install -g httpserver
cd <Extracted Zip Directory>
httpserver

Then open the website http://localhost:8080 to run the doc site.

Legal

This project is available under the Apache 2.0 License.

@haweston haweston requested a review from sheilaXu August 7, 2023 19:53
@haweston haweston changed the base branch from main to release-3.x August 7, 2023 19:53
Copy link
Contributor

@sheilaXu sheilaXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good. but can you update the PR title to be the same as commit message so it's more meaningful?

@haweston haweston changed the title Overlay event release3x fix(data overlay): add onWidgetClick and onSelectionChange event support to release 3.x Aug 8, 2023
@haweston haweston enabled auto-merge (rebase) August 8, 2023 16:35
@haweston haweston disabled auto-merge August 8, 2023 16:35
@sheilaXu sheilaXu closed this Aug 8, 2023
@sheilaXu sheilaXu reopened this Aug 8, 2023
@haweston haweston merged commit 33e500d into release-3.x Aug 8, 2023
7 checks passed
@haweston haweston deleted the overlayEventRelease3x branch August 8, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants