fix(data overlay): add onWidgetClick and onSelectionChange event support to release 3.x #1776
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Click an overlay doesn't have data binding information in the onSelectionChange event fired from the SceneViewer and the onWidgetClick event is fired at all.
Ports change to release 3.x as well
Verifying Changes
Create scene with dataoverlay that has 2+ data bindings added to it.
Connect to scene in SceneViewer mode on storybook
Click the overlay widget
verify that the storybook actions log both selection and widget change events with databindings that look like this for array of 2 data bindings:
Scene Composer
For
scene-composer
package changes specifically, you can preview the component in the published storybook artifact. To do this, wait for thePublish Storybook
action to complete below.To run the storybook build locally, you need a local static web server:
Then open the website http://localhost:8080 to run the doc site.
Legal
This project is available under the Apache 2.0 License.