Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scene composer): Added color picker to rules #1766

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

divya-sea
Copy link
Contributor

Screen Shot 2023-08-03 at 12 58 52 PM Screen Shot 2023-08-03 at 12 51 49 PM

Overview

Provide an explanation of what the change is

Verifying Changes

  • Verified color picker renders upon selecting the custom style.
  • Verified color picker display basic colors and + buttons
  • Verified Clicking on + opens up chrome picker
  • Verified selecting a color from chrome picker
  • Verified selecting a color from basic colors
  • Verified color code saves with rule target
  • Verified no regressions.

Scene Composer

For scene-composer package changes specifically, you can preview the component in the published storybook artifact. To do this, wait for the Publish Storybook action to complete below.

  • Click on the workflow details
  • Select the Summary item on the left
  • Download the zip file

To run the storybook build locally, you need a local static web server:

npm install -g httpserver
cd <Extracted Zip Directory>
httpserver

Then open the website http://localhost:8080 to run the doc site.

Legal

This project is available under the Apache 2.0 License.

This changes contain rules updated with color picker, removed unwanted effects from color picker
sufficient unit tests
@divya-sea divya-sea merged commit bb96f3b into release-3.x Aug 3, 2023
7 checks passed
@divya-sea divya-sea deleted the rule-color-picker-release-3.x branch August 3, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants