Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bedrock): prompt flows #790

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

aws-rafams
Copy link
Contributor

@aws-rafams aws-rafams commented Nov 6, 2024

Fixes #647

Draft version

  • Interfaces
  • Testing
  • Doc Updates

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.

// Execution Role
// ------------------------------------------------------
// Create base execution role
this.executionRole = new iam.Role(this, "AmazonBedrockExecutionRoleForFlows_", {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can allow the user to pass his own role

@krokoko
Copy link
Collaborator

krokoko commented Nov 7, 2024

Overall it looks good to me so far, great job @aws-rafams ! Comments:

  • We can let the user provide his own role (see comment above)
  • Maybe we could (in the future, not blocking) add addNode method(s) to Flows so it builds the FlowDefinition as you build your app, and you don't need to load them all through .fromNodes([...]) at the end

Copy link
Contributor

This pull request is now marked as stale because it hasn't seen activity for a while. Add a comment or it will be closed soon. If you wish to exclude this issue from being marked as stale, add the "backlog" label.

@github-actions github-actions bot added the stale label Dec 19, 2024
Copy link
Contributor

Closing this pull request as it hasn't seen activity for a while. Please add a comment @mentioning a maintainer to reopen. If you wish to exclude this issue from being marked as stale, add the "backlog" label.

@github-actions github-actions bot closed this Dec 22, 2024
@krokoko krokoko reopened this Dec 22, 2024
Copy link
Contributor

Closing this pull request as it hasn't seen activity for a while. Please add a comment @mentioning a maintainer to reopen. If you wish to exclude this issue from being marked as stale, add the "backlog" label.

@github-actions github-actions bot closed this Dec 25, 2024
@krokoko krokoko reopened this Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(bedrock): implement prompt flows
3 participants