misc: update isEnabledFor of s3-200-errors customization
#1346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lauzadis
added
the
no-changelog
|
A new generated diff is ready to view. |
This comment has been minimized.
This comment has been minimized.
0marperez
approved these changes
Jul 2, 2024
|
|
A new generated diff is ready to view. |
Affected ArtifactsChanged in size
|
ianbotsf
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
isEnabledForcondition of the s3-200-errors customization to only exclude streaming blobs. Previously, we would exclude the customization of any streaming members, but this does not align with the new internal specification. The change only affects a single operation,com.amazonaws.s3#SelectObjectContent, which will now have the customization applied to it where previously it didn't.Issue #
N/A
Description of changes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.