fix: Apply accessibility violation fixes #1344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsure all interactive functionality is operable with the keyboard"
…without loss of content or functionality"
|
A new generated diff is ready to view.
|
This comment has been minimized.
This comment has been minimized.
lauzadis
added
the
no-changelog
|
A new generated diff is ready to view.
|
|
A new generated diff is ready to view.
|
This comment has been minimized.
This comment has been minimized.
|
A new generated diff is ready to view.
|
lauzadis
changed the title
lauzadis
changed the title
This comment has been minimized.
This comment has been minimized.
|
A new generated diff is ready to view.
|
This comment has been minimized.
This comment has been minimized.
|
A new generated diff is ready to view.
|
This comment has been minimized.
This comment has been minimized.
0marperez
approved these changes
Jul 2, 2024
| // | ||
| /** | ||
| * Ensure that content (specifically, code blocks) reflows on small page sizes. | ||
| * Fix for accessibility violation: "Ensure pages reflow without requiring two-dimensional scrolling without loss of content or functionality" |
There was a problem hiding this comment.
style: it's a bit easier to read if we say Fixes accessibility violation: ...
| if (element.children.length > 1) { | ||
| element.insertBefore(skipLink, element.children[1]); | ||
| } else { | ||
| element.appendChild(skipLink); |
There was a problem hiding this comment.
question: do we have elements with 0 children?
There was a problem hiding this comment.
No, the leaf nodes in our documentation have 1 child which is what this condition matches.
The structure for this condition is like this:
<div sideMenuPart>
<div overview>
<div skip-to-main-content> -- added via appendChildThe other condition is for structures like like this:
<div sideMenuPart>
<div overview>
<div skip-to-main-content> -- added via insertBefore element.children[1]
<div child sideMenuPart>
<div overview>
<div child sideMenuPart>
<div overview>
<div child sideMenuPart>
<div overview>
|
|
A new generated diff is ready to view.
|
Affected ArtifactsChanged in size
|
ianbotsf
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes various docs accessibility issues:
aria-label,aria-controls,aria-expandedattributes on the left sidebar arrow button. The fix was to add these attributes to eachnavButton.Issue #
N/A
Description of changes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.