Change defaults when generating a client via smithy CLI #558
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucix-aws
approved these changes
Dec 18, 2024
wty-Bryant
approved these changes
Dec 18, 2024
Madrigal
added a commit
that referenced
this pull request
Dec 26, 2024
This reverts commit 95ba318. This feature may interact in unexpected ways with existing SDK codegen, so while we figure it out we'll roll back these changes. They will be re-applied later
Madrigal
added a commit
that referenced
this pull request
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have very old defaults currently. Update this to use our latest Go version (1.21) and add a module file, since
ref
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.