ci: add barebone e2e tests with basic awslogs scenario #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ningziwen
force-pushed
the
ziwen-e2e
branch
30 times, most recently
from
730654a to
ee87d06
Compare
ningziwen
force-pushed
the
ziwen-e2e
branch
10 times, most recently
from
a031d57 to
2abb022
Compare
ningziwen
changed the title
ningziwen
force-pushed
the
ziwen-e2e
branch
from
2abb022 to
d653eaa
Compare
ningziwen
force-pushed
the
ziwen-e2e
branch
4 times, most recently
from
335eb9a to
bc057f7
Compare
ningziwen
force-pushed
the
ziwen-e2e
branch
from
bc057f7 to
449893a
Compare
Signed-off-by: Ziwen Ning <[email protected]>
ningziwen
force-pushed
the
ziwen-e2e
branch
from
449893a to
2380241
Compare
austinvazquez
approved these changes
Sep 15, 2023
ginglis13
reviewed
Sep 15, 2023
Comment on lines
+30
to
+36
| .PHONY: test-e2e | ||
| test-e2e: | ||
| go test -timeout 30m ./e2e -test.v -ginkgo.v --binary "$(AWS_CONTAINERD_LOGGERS_BINARY)" | ||
|
|
||
| .PHONY: test-e2e-for-awslogs | ||
| test-e2e: | ||
| go test -timeout 30m ./e2e -test.v -ginkgo.v --binary "$(AWS_CONTAINERD_LOGGERS_BINARY)" --log-driver "awslogs" |
There was a problem hiding this comment.
these rules are duplicate, did you mean for the second to bee test-e2e-awslogs?
There was a problem hiding this comment.
Yeah will fix in a separated PR.
ningziwen
added a commit
that referenced
this pull request
Sep 16, 2023
*Issue #, if available:* *Description of changes:* By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice. Signed-off-by: Ziwen Ning <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.