chore: upgrade to docker 25.0.5, remove dependency on dharmadheeraj/moby fork #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haddscot
changed the title
|
I may need a refresher on this issue but can we validate assumptions with a test within shim-loggers-for-containerd given the commit seems to refer to |
|
sorry for the confusion – the bug itself was in Fargate, which called the the only change that was made in shim-loggers was to depend upon a fork of moby that would enable access to that flag before upstream merged, but newer versions of moby now recognize that flag. |
…oby fork Signed-off-by: Scott Haddlesey <[email protected]>
|
rebased – no other changes |
sondavidb
approved these changes
Apr 2, 2024
austinvazquez
approved these changes
Apr 2, 2024
henry118
approved these changes
Apr 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
this commit fixes a bug in the
CreateLogStreamAPI, but was not included in upstream moby until 23.0.0. now that we have upgraded to 23.0.3, we can remove the dependency on the forked version of moby that contained the fix. this change also bumps us to 25.0.5, since it is the latest stable version.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.