Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: addWaiterTimeoutHandling #4951

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

haozhx23
Copy link

@haozhx23 haozhx23 commented Dec 6, 2024

Issue #, if available:
the waiter_config for asynchronous inference in SageMaker SDK was unable to raise a PollingTimeoutError based on the configuration. The scenario that triggers this issue occurs when the time calculated by max_attempts * delay is less than the processing time of a single request. e.g. if the model takes 30s to process, and the waiter config setting is delay=2, max_attempts=5, the issue is triggered. The observed behavior is that the predict() method of an AsyncPredictor remains continuously blocked.

It's been found that in sagemaker-python-sdk, src/sagemaker/predictor_async.py, L253 _check_output_and_failure_paths()function, when one of the waiter exceeds max_attemps * delay, the WaiterError is catched but without any handling, so the while loop keeps checking one of the output file / failure file exists.

Description of changes:
L253 _check_output_and_failure_paths() function in src/sagemaker/predictor_async.py changed. Add a waiter_error event and checked in while condition.

Testing done:
Y

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)
  • If adding any dependency in requirements.txt files, I have spell checked and ensured they exist in PyPi

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@haozhx23 haozhx23 requested a review from a team as a code owner December 6, 2024 13:14
@haozhx23 haozhx23 requested a review from akrishna1995 December 6, 2024 13:14
@Aditi2424 Aditi2424 changed the title addWaiterTimeoutHandling fix: addWaiterTimeoutHandling Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants