Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
the
waiter_config
for asynchronous inference in SageMaker SDK was unable to raise aPollingTimeoutError
based on the configuration. The scenario that triggers this issue occurs when the time calculated bymax_attempts * delay
is less than the processing time of a single request. e.g. if the model takes 30s to process, and the waiter config setting isdelay=2
,max_attempts=5
, the issue is triggered. The observed behavior is that thepredict()
method of anAsyncPredictor
remains continuously blocked.It's been found that in sagemaker-python-sdk, src/sagemaker/predictor_async.py, L253 _check_output_and_failure_paths()function, when one of the waiter exceeds max_attemps * delay, the WaiterError is catched but without any handling, so the while loop keeps checking one of the output file / failure file exists.
Description of changes:
L253
_check_output_and_failure_paths()
function insrc/sagemaker/predictor_async.py
changed. Add a waiter_error event and checked in while condition.Testing done:
Y
Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_base
to create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.