Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO-NOT-MERGE] Fix tox.ini for installing test deps on mac #4895

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

benieric
Copy link
Contributor

Issue #, if available:

Description of changes:

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@benieric benieric requested a review from a team as a code owner October 15, 2024 21:39
@benieric benieric requested a review from sage-maker October 15, 2024 21:39
@benieric benieric changed the title Fix tox.ini for installing test deps on darwin Fix tox.ini for installing test deps on mac Oct 16, 2024
Copy link
Contributor

@edwardps edwardps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified this fixed my issue.

@benieric benieric added the do-not-merge Use when PR needs to be marked as do not merge label Oct 16, 2024
@benieric benieric changed the title Fix tox.ini for installing test deps on mac [DO-NOT-MERGE] Fix tox.ini for installing test deps on mac Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge Use when PR needs to be marked as do not merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants