[DRAFT] Support CustomAttributes / request context in handler function overrides #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial draft of a non-breaking option to support receiving an extra request context parameter in handler override functions (e.g. transform_fn, input_fn, predict_fn, output_fn) when the signature of the provided function includes the extra parameter. This should allow script mode users to access additional request context (such as the SageMaker CustomAttributes header) without breaking implementations using the existing function APIs.
nikhil-sk
suggested changes
Oct 31, 2022
| @@ -90,12 +97,46 @@ def test_transform(validate, retrieve_content_type_header, accept_key): | |||
|
|
|||
| validate.assert_called_once() | |||
| retrieve_content_type_header.assert_called_once_with(request_property) | |||
| # Since Mock()'s callable signature has only 2 args ('args', 'kwargs'), the extra 'context' arg | |||
There was a problem hiding this comment.
Nit: this comment can be removed, the test is self-explanatory.
|
Hello, I was also looking for this feature. Any progress? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #110
Description of changes:
Initial draft of a non-breaking option to support passing an extra "request context" parameter to handler override functions (
transform_fn,input_fn,predict_fn,output_fn), ONLY when the signature of the provided function includes the extra parameter.This should allow script mode users to access additional request context (such as the SageMaker CustomAttributes header) without breaking implementations using the existing function APIs.
Outstanding TODOs (hoping for input from reviewers!) include:
contextobject as perTransformer.transform()seems maybe too broad & not very user-friendly? I'm not even sure what API it offersTesting done:
Added some unit tests to show initial non-breaking-ness, but would be nice to get an integration test too maybe?
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
I have used the regional endpoint when creating S3 and/or STS clients (if appropriate)Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.