Fixed UT run_pysdk_tests.sh #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How many test cases are left after removing these? Do you know the percentage number? |
|
So 8028 passed, 3778 skipped and 27 deselected |
TRNWWZ
reviewed
Nov 13, 2024
| @@ -8,13 +8,44 @@ git checkout tags/v$pysdk_version | |||
|
|
|||
| # Install test dependencies of sagemaker-python-sdk | |||
| # Using pip as some of the packages are not available on conda-forge | |||
| pip install -r requirements/extras/test_requirements.txt | |||
| pip install --use-deprecated=legacy-resolver -r requirements/extras/test_requirements.txt | |||
There was a problem hiding this comment.
What does --use-deprecated=legacy-resolver do?
There was a problem hiding this comment.
yeah so without using it, getting the following error :
The conflict is caused by:
onnx 1.15.0 depends on protobuf>=3.20.2
tensorflow 2.12.0 depends on protobuf!=4.21.0, 1=4.21.1, 1=4.21.2, 1=4.21.3, 1=4.21.4, 1=4.21.5, <5.0.0dev and >=3.20.3
mlflow 2.12.2 depends on protobuf<5 and >=3.12.0
tensorboard 2.12.0 depends on protobuf>=3.19.6
opentelemetry-proto 1.28.0 depends on protobuf<6.0 and >=5.0
so for opentelemetry-proto 1.28.0, protobuf version should be >=5.0 and the current protobuf Version: 4.25.3
To resolve this, flag --use-deprecated=legacy-resolver is being added.
TRNWWZ
approved these changes
Nov 13, 2024
aws-tianquaw
approved these changes
Nov 15, 2024
claytonparnell
approved these changes
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #316
Description of changes:
Skipped those test cases which needs credentials, or Docker daemon as it cannot be provided in SMD image as of now.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.