Release v0.13.0 #456
Merged
Release v0.13.0 #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claytonparnell
previously approved these changes
Jul 22, 2024
JunLyu
reviewed
Jul 23, 2024
Comment on lines
5
to
6
| # Sagemaker Python SDK's unit tests requires AWS_DEFAULT_REGION to be set. So, using an arbitrary value of us-east-1 | ||
| export AWS_DEFAULT_REGION=us-west-2 |
Comment on lines
-8
to
-9
| # Sagemaker Python SDK's unit tests requires AWS_DEFAULT_REGION to be set. So, using an arbitrary value of us-east-1 | ||
| ENV AWS_DEFAULT_REGION=us-east-1 |
There was a problem hiding this comment.
It's designed to work in same way as the change I made above,
# Sagemaker Python SDK's unit tests requires AWS_DEFAULT_REGION to be set. So, using an arbitrary value of us-east-1
export AWS_DEFAULT_REGION=us-west-2
But it's not effective as tested locally. So removing it and count on commands in shell file directly.
|
|
||
| # Enforce dependencies are all installed from conda-forge | ||
| RUN conda config --remove channels defaults | ||
| RUN micromamba config append channels conda-forge --env |
There was a problem hiding this comment.
https://mamba.readthedocs.io/en/latest/installation/micromamba-installation.html
Why not use the exact command?
micromamba config append channels conda-forge
micromamba config set channel_priority strict
There was a problem hiding this comment.
Without --env, image build job would fail:
Step 28/45 : RUN micromamba config append channels conda-forge
---> Running in 43cce551b89b
Traceback (most recent call last):
File "/local/home/ruinon/sagemaker-distribution-dev/src/main.py", line 441, in <module>
parse_args(get_arg_parser())
File "/local/home/ruinon/sagemaker-distribution-dev/src/main.py", line 437, in parse_args
args.func(args)
File "/local/home/ruinon/sagemaker-distribution-dev/src/main.py", line 183, in build_images
image_ids, image_versions = _build_local_images(target_version, args.target_ecr_repo, args.force, args.skip_tests)
File "/local/home/ruinon/sagemaker-distribution-dev/src/main.py", line 250, in _build_local_images
image, log_gen = _docker_client.images.build(
File "/home/ruinon/anaconda3/envs/sagemaker-distribution/lib/python3.10/site-packages/docker/models/images.py", line 304, in build
raise BuildError(chunk['error'], result_stream)
docker.errors.BuildError: The command '/usr/local/bin/_dockerfile_shell.sh micromamba config append channels conda-forge' returned a non-zero code: 139
I tried specify USER root before executing the command but getting same error. So adding --env here
JunLyu
previously approved these changes
Jul 23, 2024
| @@ -0,0 +1,32 @@ | |||
| # Release notes: 0.13.0 | |||
|
|
|||
There was a problem hiding this comment.
Can you manually leave a note that we upgraded Python from 3.8 to 3.11
template/v0/Dockerfile
Outdated
| @@ -62,6 +62,11 @@ RUN micromamba install -y --name base --file /tmp/$ENV_IN_FILENAME && \ | |||
| ARG MAMBA_DOCKERFILE_ACTIVATE=1 | |||
| RUN sudo ln -s $(which python3) /usr/bin/python | |||
|
|
|||
| # Enforce dependencies are all installed from conda-forge | |||
| RUN conda config --remove channels defaults | |||
There was a problem hiding this comment.
Does it have conda-forge now ?
There was a problem hiding this comment.
Yes:
dev-dsk-ruinon-2a-ba2bf164 % docker run -it b0934903332f
(base) sagemaker-user@f19adfc37c06:~$ conda config --show channels
channels:
- conda-forge
(base) sagemaker-user@f19adfc37c06:~$ exit
exit
(base)
(24-07-24 21:33:41) <0> [~/sagemaker-distribution-dev]
dev-dsk-ruinon-2a-ba2bf164 % docker run -it 4325ba0a6498
(base) sagemaker-user@5e786705f97c:~$ conda config --show channels
channels:
- conda-forge
(base) sagemaker-user@5e786705f97c:~$
balajisankar15
previously approved these changes
Jul 25, 2024
added 2 commits
August 1, 2024 00:54
aws-tianquaw
reviewed
Aug 1, 2024
added 2 commits
August 1, 2024 02:45
Python Package Size Report (GPU)Target Image Version: 0.13.0 | Base Image Version: 0.12.0Python Packages Total Size Summary
Top-20 Largest Python Packages
Python Package Size DeltaThe total size of newly introduced Python packages is 57.56MB, accounts for 1.77% of the total package size.
Python Package Size Report (CPU)Target Image Version: 0.13.0 | Base Image Version: 0.12.0Python Packages Total Size Summary
Top-20 Largest Python Packages
Python Package Size DeltaThe total size of newly introduced Python packages is 103.15MB, accounts for
|
|
Source of new installed packages: |
balajisankar15
approved these changes
Aug 6, 2024
JunLyu
approved these changes
Aug 6, 2024
claytonparnell
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
release v0.13.0
Description of changes:
Staleness Report: 0.13.0(gpu)
Staleness Report: 0.13.0(cpu)
Unit test report:
CPU unit test failure:
keras - failed due to test case's own issue, code base not owned by us
pandas - All failed tests have error like
ValueError: Could not find file..., should be test case own issuesm-python-sdk - known issue: #316
GPU unit test failure:
scipy - known issue: #30
keras - known issue: #413
pandas - All failed tests have error like
ValueError: Could not find file..., should be test case own issuesm-python-sdk - known issue: #316
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.