Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SageMaker JupyterLab extensions, jupyter-server-proxy and SageMaker scheduler #125

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

zuoyuanh
Copy link
Contributor

@zuoyuanh zuoyuanh commented Nov 2, 2023

Issue #, if available:

#98
#115

Description of changes:

Add SageMaker JupyterLab extensions, jupyter-server-proxy and SageMaker scheduler

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@zuoyuanh zuoyuanh requested a review from just4brown November 2, 2023 14:37
@just4brown
Copy link
Contributor

Two issues with testing came up for this release, neither are blockers.

Scipy GPU failures

Similar to a known issue, just presented in a new way. Added notes to the open issue: #30

pandas GPU failures

Pandas recently made a change to how the structure of the tests which causes a new failure for all 2.0+ versions (repo'd the same issues across previous sagemaker distribution versions that previously were passing).

There's a fix for the 0.x.y series in another PR, will followup with a PR to fix this for 1.x.y
Added details to open pandas issue: #110

@just4brown just4brown merged commit 2d5f44f into aws:main Nov 2, 2023
@just4brown just4brown added this to the v1.1.0 Release milestone Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants