Disable rtc for ydoc extension

aws · Nov 20, 2024 · 493ecb0 · 493ecb0
1 parent 9304f47
commit 493ecb0
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 6 deletions.
diff --git a/build_artifacts/v3/v3.0/v3.0.0/dirs/usr/local/bin/start-jupyter-server b/build_artifacts/v3/v3.0/v3.0.0/dirs/usr/local/bin/start-jupyter-server
@@ -19,7 +19,8 @@ if [ -n "$SAGEMAKER_APP_TYPE_LOWERCASE" ] && [ "$SAGEMAKER_SPACE_TYPE_LOWERCASE"
     --ServerApp.allow_origin='*' \
     --collaborative \
     --ServerApp.identity_provider_class=sagemaker_jupyterlab_extension_common.identity.SagemakerIdentityProvider \
-    --YDocExtension.ystore_class=sagemaker_jupyterlab_extension_common.ydoc_override.ydoc.MySQLiteYStore
+    --YDocExtension.ystore_class=sagemaker_jupyterlab_extension_common.ydoc_override.ydoc.MySQLiteYStore \
+    --YDocExtension.disable_rtc=True
 
 # Start Jupyter server
 elif [ -n "$SAGEMAKER_APP_TYPE_LOWERCASE" ]; then
@@ -28,9 +29,11 @@ elif [ -n "$SAGEMAKER_APP_TYPE_LOWERCASE" ]; then
   jupyter lab --ip 0.0.0.0 --port 8888 \
     --ServerApp.base_url="/$SAGEMAKER_APP_TYPE_LOWERCASE/default" \
     --ServerApp.token='' \
-    --ServerApp.allow_origin='*'
+    --ServerApp.allow_origin='*' \
+    --YDocExtension.disable_rtc=True
 else
   jupyter lab --ip 0.0.0.0 --port 8888 \
     --ServerApp.token='' \
-    --ServerApp.allow_origin='*'
+    --ServerApp.allow_origin='*' \
+    --YDocExtension.disable_rtc=True
 fi
diff --git a/template/v3/dirs/usr/local/bin/start-jupyter-server b/template/v3/dirs/usr/local/bin/start-jupyter-server
@@ -19,7 +19,8 @@ if [ -n "$SAGEMAKER_APP_TYPE_LOWERCASE" ] && [ "$SAGEMAKER_SPACE_TYPE_LOWERCASE"
     --ServerApp.allow_origin='*' \
     --collaborative \
     --ServerApp.identity_provider_class=sagemaker_jupyterlab_extension_common.identity.SagemakerIdentityProvider \
-    --YDocExtension.ystore_class=sagemaker_jupyterlab_extension_common.ydoc_override.ydoc.MySQLiteYStore
+    --YDocExtension.ystore_class=sagemaker_jupyterlab_extension_common.ydoc_override.ydoc.MySQLiteYStore \
+    --YDocExtension.disable_rtc=True
 
 # Start Jupyter server
 elif [ -n "$SAGEMAKER_APP_TYPE_LOWERCASE" ]; then
@@ -28,9 +29,11 @@ elif [ -n "$SAGEMAKER_APP_TYPE_LOWERCASE" ]; then
   jupyter lab --ip 0.0.0.0 --port 8888 \
     --ServerApp.base_url="/$SAGEMAKER_APP_TYPE_LOWERCASE/default" \
     --ServerApp.token='' \
-    --ServerApp.allow_origin='*'
+    --ServerApp.allow_origin='*' \
+    --YDocExtension.disable_rtc=True
 else
   jupyter lab --ip 0.0.0.0 --port 8888 \
     --ServerApp.token='' \
-    --ServerApp.allow_origin='*'
+    --ServerApp.allow_origin='*' \
+    --YDocExtension.disable_rtc=True
 fi