Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove www.mozilla.com from well-known to unblock CI #4880

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

toidiu
Copy link
Contributor

@toidiu toidiu commented Nov 8, 2024

Description of changes:

The www.mozilla.org endpoint is flaky. This PR comments out the mozilla endpoint to unblock CI while we work on a long-term fix.

Callout:

From the test logs we see that we actually do connect to www.mozilla.com (Connected to www.mozilla.org:443) and the failure seems to be related to our testing framework.

s2nc: stdout available
s2nc: looking for send_marker s2n is ready in b'libcrypto: AWS-LC 1.36.0\nCONNECTED:\nHandshake: NEGOTIATED|FULL_HANDSHAKE|TLS ...(412 more bytes)
s2nc: found s2n is ready
s2nc: will send nothing
s2nc: finished sending
s2nc: closing stdin
s2nc: stdout available
s2nc: stdout available
Command line: s2nc --non-blocking -e -T -f ../pems/trust-store/ca-bundle.crt -c test_all_tls12 www.mozilla.org 443
Exit code: -9
Stdout: libcrypto: AWS-LC 1.36.0
CONNECTED:
Handshake: NEGOTIATED|FULL_HANDSHAKE|TLS12_PERFECT_FORWARD_SECRECY
Client hello version: 33
Client protocol version: 33
Server protocol version: 33
Actual protocol version: 33
Server name: www.mozilla.org
Curve: secp256r1
Cipher negotiated: ECDHE-RSA-AES128-GCM-SHA256
Server signature negotiated: RSA-PSS-RSAE+SHA256
Early Data status: NOT REQUESTED
Wire bytes in: 3072
Wire bytes out: 341
s2n is ready
Connected to www.mozilla.org:443

Testing:

Other well-known endpoints should continue to work.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added the s2n-core team label Nov 8, 2024
@toidiu toidiu marked this pull request as ready for review November 8, 2024 18:01
Copy link
Contributor

@jmayclin jmayclin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: probably worth including the successful connection log in the PR description?

E.g. "we are confident that this isn't an s2n-tls issue. We expect that this is just an issue with our test framework coordination".

@toidiu toidiu enabled auto-merge (squash) November 8, 2024 19:36
@toidiu
Copy link
Contributor Author

toidiu commented Nov 8, 2024

The s2nUnitCRT test failing is being addressed in this issue and being fixed in this PR

@lrstewart lrstewart disabled auto-merge November 8, 2024 23:28
@lrstewart lrstewart merged commit 12b140a into aws:main Nov 8, 2024
37 of 38 checks passed
@lrstewart lrstewart deleted the ak-well-known branch November 8, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants