fix: enable -Wcast-qual flag for libcrypto=awslc #4735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove the condition which only add -Wcast-qual back for non AWS-lc Libcrypto.
goatgoose
reviewed
Aug 27, 2024
| # add cast-qual back in for non AWS-LC | ||
| target_compile_options(${PROJECT_NAME} PRIVATE -Wcast-qual) | ||
| endif() | ||
| target_compile_options(${PROJECT_NAME} PRIVATE -Wcast-qual) |
There was a problem hiding this comment.
Is there still a reason to have this flag separated from all of the other flags? I wonder if it should just be added to the rest of the options:
Lines 137 to 140 in ada65a7
There was a problem hiding this comment.
The readability will be improved if we put the flag into all of this. I will add -Wcast-qual to this part.
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
Resolve issue #4710
Description of changes:
Call-outs:
awslcupdate for ubuntu18.Testing:
S2N_LIBCRYPTO=openssl.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.