Fix build on macOS 10.15 and earlier #4674
Conversation
|
The team has discussed this PR and concluded that s2n-tls won't be able to support MacOS versions that Apple does not support. MacOS Catalina has been unsupported by Apple since 2022. We have no mechanism to reproduce your problem or test this fix, and couldn't guarantee that s2n-tls would continue to work with Catalina in the future even if we fixed this issue. With that in mind, redefining "__DARWIN_ALIGN32" based on MacOS version is a fairly specific and complex solution to this problem and not one I'm comfortable merging, especially not without automated testing. I did see this, however. Would switching from "= { 0 }" to memset for initialization fix your problem? That would essentially be a no-op change, and not Catalina-specific. |
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Sorry, I will return to this. |
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Resolved issues:
Resolves #4673
Description of changes:
Currently the build is broken on every macOS from Catalina down, both with gcc and clang.
This fixes it.
Verified on 10.6, but we know it works on other systems too.