CRT cmake failure

[dougch]

Security issue notifications

If you discover a potential security issue in s2n we ask that you notify
AWS Security via our vulnerability reporting page. Please do not create a public github issue.

Problem:

CMake is failing to find @[email protected]

-- LibCrypto Include Dir: /tmp/tmp.C3vZpVFExW/build/deps/AWSLC/install/include
-- LibCrypto Shared Lib:  /usr/lib/x86_64-linux-gnu/libcrypto.so
-- LibCrypto Static Lib:  /tmp/tmp.C3vZpVFExW/build/deps/AWSLC/install/lib/libcrypto.a
CMake Error at /opt/s2n-tls/cmake/s2n-config.cmake:23 (include):
  include could not find load file:
    /opt/s2n-tls/cmake/shared/@[email protected]
Call Stack (most recent call first):
  crt/aws-c-io/CMakeLists.txt:157 (find_package)
-- Using prebuilt libcrypto from AWS-LC
-- LibCrypto Include Dir: /tmp/tmp.C3vZpVFExW/build/deps/AWSLC/install/include
-- LibCrypto Shared Lib:  /usr/lib/x86_64-linux-gnu/libcrypto.so
-- LibCrypto Static Lib:  /tmp/tmp.C3vZpVFExW/build/deps/AWSLC/install/lib/libcrypto.a
-- Configuring incomplete, errors occurred!

example run from a schedule test against main: https://us-west-2.console.aws.amazon.com/codesuite/codebuild/024603541914/projects/s2nGeneralBatch/build/s2nGeneralBatch%3A13253f48-3ee0-46e2-918b-b60cbcffd40f?region=us-west-2

Solution:

A description of the possible solution in terms of S2N architecture. Highlight and explain any potentially controversial design decisions taken.

• Does this change what S2N sends over the wire? If yes, explain.
• Does this change any public APIs? If yes, explain.
• Which versions of TLS will this impact?

Requirements / Acceptance Criteria:

What must a solution address in order to solve the problem? How do we know the solution is complete?

• RFC links: Links to relevant RFC(s)
• Related Issues: Link any relevant issues
• Will the Usage Guide or other documentation need to be updated?
• Testing: How will this change be tested? Call out new integration tests, functional tests, or particularly interesting/important unit tests.
  • Will this change trigger SAW changes? Changes to the state machine, the s2n_handshake_io code that controls state transitions, the DRBG, or the corking/uncorking logic could trigger SAW failures.
  • Should this change be fuzz tested? Will it handle untrusted input? Create a separate issue to track the fuzzing work.

Out of scope:

Is there anything the solution will intentionally NOT address?

[dougch]

Related changes? #4876, #4465 and awslabs/aws-crt-cpp#677

[dougch]

It would be nice to understand how CMake is finding this path, a worthwhile investigation might be forcefully pair down these search paths, so we aren't surprised when it pulls in system files or random other git clones.