Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dev script also installs packages in ui-tests #212

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

Jurredr
Copy link
Contributor

@Jurredr Jurredr commented Dec 23, 2024

Problem

Packages were not installed in ui-tests when running dev script, which gave import errors after cleaning and rebuilding the main package.

Solution

Also cd into the ui-tests and run an npm install.

Tests (NA)

- [ ] I have tested this change on VSCode
- [ ] I have tested this change on JetBrains

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Jurredr Jurredr added the improvement Improvement of an existing feature label Dec 23, 2024
@Jurredr Jurredr self-assigned this Dec 23, 2024
@Jurredr Jurredr requested a review from a team as a code owner December 23, 2024 11:25
@Jurredr Jurredr merged commit edde7f7 into main Dec 23, 2024
2 checks passed
@Jurredr Jurredr deleted the jurredr/fix-dev-script branch December 23, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants