-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new syntax highlighter #211
Merged
Merged
+297
−265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jurredr
added
new feature
New feature or request
improvement
Improvement of an existing feature
labels
Dec 20, 2024
dogusata
requested changes
Dec 23, 2024
2 more important things:
|
dogusata
requested changes
Dec 24, 2024
dogusata
previously approved these changes
Dec 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added just a small nit related with the 3rd party clone usage and comments. Please remove the comments in your next pr, if we're not using it directly from node_modules for some reason, the code should follow our guidelines not anyone elses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The current syntax highlighter lacks proper tokenization control, thus leading to unattractive syntax highlighting.
Solution
Swap out
prism.js
byhighlight.js
. The libraryshiki.js
has also been considered, but has not been used given its strictly asynchronous nature.Old
New
Important note
A proper color mapping still needs to be added, possibly a dynamic one consuming variables from VSCode.
Tests
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.