Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add E2E tests for voting and feedback form #209

Merged
merged 10 commits into from
Dec 20, 2024
Merged

Conversation

Jurredr
Copy link
Contributor

@Jurredr Jurredr commented Dec 19, 2024

Problem

There were no end to end tests for voting and feedback forms yet.

Solution

Added 6 new flows for testing this E2E.

Extra

Cleaned up a bunch of unnecessary use of backticks (`) and await keywords throughout all E2E tests.

Tests (NA)

- [ ] I have tested this change on VSCode
- [ ] I have tested this change on JetBrains

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Jurredr Jurredr added the testing Improvements to the testing suite label Dec 19, 2024
@Jurredr Jurredr self-assigned this Dec 19, 2024
@Jurredr Jurredr requested a review from a team as a code owner December 19, 2024 15:25
Copy link
Contributor

@francescoopiccoli francescoopiccoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall great work! Just a few comments, mostly for my understanding, I approve but make sure to remove the changes in chat-prompt-input

@francescoopiccoli francescoopiccoli self-requested a review December 20, 2024 08:50
@Jurredr Jurredr merged commit 0258da8 into main Dec 20, 2024
2 checks passed
@Jurredr Jurredr deleted the jurredr/feedback-form-e2e branch December 20, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Improvements to the testing suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants