Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Improve CAS to Karpenter migration steps for clarity and automation #7343

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

mozammil89
Copy link

Fixes #N/A

Description

  • Added CloudFormation template to automate setup of IAM role, policy, and interruption queue for EC2 events.
  • Refined security group tagging, separating SG configurations for Launch Templates for better clarity.
  • Simplified Karpenter deployment by passing node affinity settings directly to the Helm chart, eliminating the need for manual CRD installation.
  • Made minor updates to improve overall readability and clarity in the documentation.

How was this change tested?

  • Doc updates tested locally with hugo server
  • Dry-run of steps in an existing EKS cluster with managed node group

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • [] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mozammil89 mozammil89 requested a review from a team as a code owner November 7, 2024 04:30
@mozammil89 mozammil89 requested a review from jmdeal November 7, 2024 04:30
Copy link

netlify bot commented Nov 7, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 2ac359e
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/673b378f1336e3000801bfdf

@mozammil89
Copy link
Author

@mariuskimmina Thank you for reviewing PR. I've addressed your review comments. Could you please recheck and let me know if further feedback is required? If everything looks good, kindly approve the PR.

Copy link
Author

@mozammil89 mozammil89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've addressed all the review comments.

@mozammil89
Copy link
Author

mozammil89 commented Nov 27, 2024

Issue: #7394

Copy link

@mariuskimmina mariuskimmina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good improvement to me, also left a message in Slack trying to get more eyes on it

Copy link
Contributor

This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity.

@jonathan-innis
Copy link
Contributor

Assigning this to @njtran to figure out how we keep this data up-to-date as we make changes to our base Getting Started Guide. I think the challenge here is that we often make changes to one and not the other.

@mozammil89
Copy link
Author

Assigning this to @njtran to figure out how we keep this data up-to-date as we make changes to our base Getting Started Guide. I think the challenge here is that we often make changes to one and not the other.

The majority of customers I work with already have existing EKS clusters and naturally follow the CAS to Karpenter migration path. You’re absolutely right that both guides need to be updated in parallel. Please feel free to reach out to me on Slack at @mozkhan if you need any additional information for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants