-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Improve CAS to Karpenter migration steps for clarity and automation #7343
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for karpenter-docs-prod canceled.
|
website/content/en/preview/getting-started/migrating-from-cas/_index.md
Outdated
Show resolved
Hide resolved
website/content/en/preview/getting-started/migrating-from-cas/_index.md
Outdated
Show resolved
Hide resolved
@mariuskimmina Thank you for reviewing PR. I've addressed your review comments. Could you please recheck and let me know if further feedback is required? If everything looks good, kindly approve the PR. |
website/content/en/preview/getting-started/migrating-from-cas/_index.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've addressed all the review comments.
website/content/en/preview/getting-started/migrating-from-cas/_index.md
Outdated
Show resolved
Hide resolved
website/content/en/preview/getting-started/migrating-from-cas/_index.md
Outdated
Show resolved
Hide resolved
website/content/en/preview/getting-started/migrating-from-cas/_index.md
Outdated
Show resolved
Hide resolved
Issue: #7394 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a good improvement to me, also left a message in Slack trying to get more eyes on it
This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity. |
Assigning this to @njtran to figure out how we keep this data up-to-date as we make changes to our base Getting Started Guide. I think the challenge here is that we often make changes to one and not the other. |
The majority of customers I work with already have existing EKS clusters and naturally follow the CAS to Karpenter migration path. You’re absolutely right that both guides need to be updated in parallel. Please feel free to reach out to me on Slack at @mozkhan if you need any additional information for this PR. |
Fixes #N/A
Description
How was this change tested?
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.