Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(python): support inheritance-based interface implementation #3350

Draft
wants to merge 22 commits into
base: main
Choose a base branch
from

Merge remote-tracking branch 'origin/main' into rmuller/python-interf…

5885996
Select commit
Loading
Failed to load commit list.
Draft

feat(python): support inheritance-based interface implementation #3350

Merge remote-tracking branch 'origin/main' into rmuller/python-interf…
5885996
Select commit
Loading
Failed to load commit list.
Mergify / Summary succeeded Dec 17, 2024 in 2s

1 rule matches and 9 potential rules

✅ Rule: label core (label)

  • -label~="contribution/core"
  • author~=^(RomainMuller|rix0rrr|iliapolo|comcalvi|kaizencc|corymhall|otaviomacedo|TheRealAmazonKendra|vinayak-kukreja|mrgrain|colifran|mikewrighton|paulhcsun)$

Rule: Tell them we're good now (comment, label)

  • #approved-reviews-by>=1
  • label!=pr/do-not-merge
  • status-success=Integration test (jsii-pacmak)
  • status-success=Unit Tests
  • status-success=Validate PR Title
  • #changes-requested-reviews-by=0
  • #review-requested=0
  • -approved-reviews-by~=author
  • -closed
  • -merged
  • -title~=(WIP|wip)
  • label!=pr/blocked
  • label!=pr/ready-to-merge

Rule: Synchronize that PR to upstream and merge it (squash) (queue)

  • #approved-reviews-by>=1
  • -draft [📌 queue requirement]
  • label!=pr/do-not-merge
  • label=pr/ready-to-merge
  • status-success=Integration test (jsii-pacmak)
  • status-success=Unit Tests
  • status-success=Validate PR Title
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default-squash]
      • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
      • any of: [🛡 GitHub branch protection]
        • check-neutral = Integration test (jsii-pacmak)
        • check-skipped = Integration test (jsii-pacmak)
        • check-success = Integration test (jsii-pacmak)
      • any of: [🛡 GitHub branch protection]
        • check-neutral = Build
        • check-skipped = Build
        • check-success = Build
      • any of: [🛡 GitHub branch protection]
        • check-neutral = Unit Tests
        • check-skipped = Unit Tests
        • check-success = Unit Tests
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by=0
  • #review-requested=0
  • -approved-reviews-by~=author
  • -closed
  • -closed [📌 queue requirement]
  • -conflict [📌 queue requirement]
  • -merged
  • -title~=(WIP|wip)
  • label!=pr/blocked
  • label!=pr/no-squash
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed

Rule: Synchronize that PR to upstream and merge it (squash) (comment, dismiss_reviews)

  • #approved-reviews-by>=1
  • label!=pr/do-not-merge
  • label=pr/ready-to-merge
  • status-success=Integration test (jsii-pacmak)
  • status-success=Unit Tests
  • status-success=Validate PR Title
  • #changes-requested-reviews-by=0
  • #review-requested=0
  • -approved-reviews-by~=author
  • -closed
  • -merged
  • -title~=(WIP|wip)
  • label!=pr/blocked
  • label!=pr/no-squash

Rule: Synchronize that PR to upstream and merge it (no-squash) (queue)

  • #approved-reviews-by>=1
  • -draft [📌 queue requirement]
  • label!=pr/do-not-merge
  • label=pr/no-squash
  • label=pr/ready-to-merge
  • status-success=Integration test (jsii-pacmak)
  • status-success=Unit Tests
  • status-success=Validate PR Title
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default-merge]
      • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
      • any of: [🛡 GitHub branch protection]
        • check-neutral = Integration test (jsii-pacmak)
        • check-skipped = Integration test (jsii-pacmak)
        • check-success = Integration test (jsii-pacmak)
      • any of: [🛡 GitHub branch protection]
        • check-neutral = Build
        • check-skipped = Build
        • check-success = Build
      • any of: [🛡 GitHub branch protection]
        • check-neutral = Unit Tests
        • check-skipped = Unit Tests
        • check-success = Unit Tests
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by=0
  • #review-requested=0
  • -approved-reviews-by~=author
  • -closed
  • -closed [📌 queue requirement]
  • -conflict [📌 queue requirement]
  • -merged
  • -title~=(WIP|wip)
  • label!=pr/blocked
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed

Rule: Synchronize that PR to upstream and merge it (no-squash) (comment, dismiss_reviews)

  • #approved-reviews-by>=1
  • label!=pr/do-not-merge
  • label=pr/no-squash
  • label=pr/ready-to-merge
  • status-success=Integration test (jsii-pacmak)
  • status-success=Unit Tests
  • status-success=Validate PR Title
  • #changes-requested-reviews-by=0
  • #review-requested=0
  • -approved-reviews-by~=author
  • -closed
  • -merged
  • -title~=(WIP|wip)
  • label!=pr/blocked

Rule: Clean branch up (delete_head_branch)

  • closed [📌 delete_head_branch requirement]
  • merged

Rule: Remove Label (label)

  • merged

Rule: Discard stale reviews (dismiss_reviews)

  • label!=contribution/core
  • author!=dependabot-preview[bot]
  • author!=dependabot[bot]
  • base=main

Rule: Let them know the PR title doesn't look right (comment)

  • status-failure=Validate PR Title

💖  Mergify is proud to provide this service for free to open source projects.

🚀  You can help us by becoming a sponsor!


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com