fix: use maps instead of literals in configureCategories (backport #…

…1598) (#1601)

# Backport

This will backport the following commits from `main` to
`maintenance/v5.6`:
- [fix: use maps instead of literals in `configureCategories`
(#1598)](#1598)

<!--- Backport version: 9.5.1 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

Co-authored-by: Eli Polonsky <[email protected]>

src/jsii-diagnostic.ts

@@ -86,13 +86,13 @@ export class Code<T extends DiagnosticMessageFormatter = DiagnosticMessageFormat
    */
   public static lookup(codeOrName: string | number): Code | undefined {
     if (typeof codeOrName === 'number') {
-      return this.byCode[codeOrName];
+      return this.byCode.get(codeOrName);
     }
-    return this.byName[codeOrName];
+    return this.byName.get(codeOrName);
   }
 
-  private static readonly byCode: { [code: number]: Code } = {};
-  private static readonly byName: { [name: string]: Code } = {};
+  private static readonly byCode: Map<number, Code> = new Map();
+  private static readonly byName: Map<string, Code> = new Map();
 
   // eslint-disable-next-line @typescript-eslint/explicit-member-accessibility
   readonly #defaultCategory: ts.DiagnosticCategory;
@@ -126,7 +126,8 @@ export class Code<T extends DiagnosticMessageFormatter = DiagnosticMessageFormat
     if (name in Code.byName) {
       throw new Error(`Attempted to create two instances of ${this.constructor.name} with name ${name}`);
     }
-    Code.byCode[code] = Code.byName[name] = this;
+    Code.byCode.set(code, this);
+    Code.byName.set(name, this);
   }
 
   /**

test/jsii-diagnostic.test.ts

@@ -9,6 +9,12 @@ describe('jsii diagnostics', () => {
       code.category = DiagnosticCategory.Suggestion;
     });
 
+    test('throws on __proto__ key', () => {
+      expect(() => configureCategories(JSON.parse('{"__proto__":{"pollutedKey":123}}'))).toThrow(
+        `Unrecognized diagnostic code '__proto__'`,
+      );
+    });
+
     test('diagnostic by name', () => {
       configureCategories({
         'metadata/package-json-missing-description': DiagnosticCategory.Error,