Skip to content

Commit

Permalink
harbor no longer needs to skip go mod download
Browse files Browse the repository at this point in the history
harbor vendors its go mods and there used to be a patch that changed files in the vendor directory. setting this flag was necessary to avoid losing the change since go mod download happened after patching. see aws/eks-distro#3008 for more info. I will send another PR adding a similar check to this repo to catch this kind of in the future automatically.
  • Loading branch information
jaxesn authored Jun 3, 2024
1 parent 5db99ce commit ddf1637
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion projects/goharbor/harbor/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ SOURCE_PATTERNS=./core ./jobservice ./registryctl ./cmd/migrate-patch ./cmd/stan
# harbor-core has additional ldflags
BINARY_TARGET_FILES_BUILD_ALONE=harbor-core
GO_MOD_PATHS=src src src src src src
GO_MODS_VENDORED=true

TRIVY_VERSION=$(TRIVYVERSION)
IMAGE_BUILD_ARGS=TRIVY_VERSION
Expand Down

0 comments on commit ddf1637

Please sign in to comment.