fix(auth): debounce getToken() function #6282
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
The Identity team noticed a large spike in token refreshes for specific users. One user would trigger refresh over 50 times within a few seconds.
Ticket:
P180886632
Solution:
The telemetry showed that
getChatAuthState()
was being called many times in a short period. This eventually triggered the token refresh logic many times, if the token was expired.The solution is to add a debounce to
getToken()
which calls the refresh logic.debounce()
only accepts functions without any args, the refresh logic requires argsgetToken()
will also load from disk is the token is not expired, so debouncing here saves disk I/O as well.The current debounce interval is 100 milliseconds, which based on telemetry should be enough to capture the barrage of calls. With some manual testing it does not feel like UX is impacted in any noticeable way.
feature/x
branches will not be squash-merged at release time.