-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(amazonq): add view summary button in chat #6270
base: master
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we still keeping the functionality in this file that automatically shows the summary when the user downloads the proposed changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. It auto-opens
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add an e2e test for this as well?
@@ -153,6 +154,21 @@ describe('Amazon Q Code Transformation', function () { | |||
const jdkPathResponse = tab.getChatItems().pop() | |||
// this 'Sorry' message is OK - just making sure that the UI components are working correctly | |||
assert.strictEqual(jdkPathResponse?.body?.includes("Sorry, I couldn't locate your Java installation"), true) | |||
|
|||
transformByQState.setSummaryFilePath(path.join(os.tmpdir(), 'summary.md')) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
createTestWorkspaceFolder
export async function createTestWorkspaceFolder(name?: string, subDir?: string): Promise<vscode.WorkspaceFolder> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deprecated, so I used TestFolder
/runIntegrationTests |
Note to self: try setting |
Problem
A "View summary" button was missing in the chat, which made it difficult for users to re-open their transformation summary once they closed it.
Solution
Add the button.
feature/x
branches will not be squash-merged at release time.License: I confirm that my contribution is made under the terms of the Apache 2.0 license.