Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(amazonq): add view summary button in chat #6270

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dhasani23
Copy link
Contributor

Problem

A "View summary" button was missing in the chat, which made it difficult for users to re-open their transformation summary once they closed it.

Solution

Add the button.


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.

License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dhasani23 dhasani23 requested review from a team as code owners December 17, 2024 22:20
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we still keeping the functionality in this file that automatically shows the summary when the user downloads the proposed changes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It auto-opens

Copy link
Contributor

@jpinkney-aws jpinkney-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add an e2e test for this as well?

@@ -153,6 +154,21 @@ describe('Amazon Q Code Transformation', function () {
const jdkPathResponse = tab.getChatItems().pop()
// this 'Sorry' message is OK - just making sure that the UI components are working correctly
assert.strictEqual(jdkPathResponse?.body?.includes("Sorry, I couldn't locate your Java installation"), true)

transformByQState.setSummaryFilePath(path.join(os.tmpdir(), 'summary.md'))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

createTestWorkspaceFolder

export async function createTestWorkspaceFolder(name?: string, subDir?: string): Promise<vscode.WorkspaceFolder> {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deprecated, so I used TestFolder

@dhasani23 dhasani23 requested a review from justinmk3 December 19, 2024 20:34
@dhasani23
Copy link
Contributor Author

dhasani23 commented Dec 20, 2024

/runIntegrationTests

@dhasani23 dhasani23 marked this pull request as draft December 23, 2024 17:08
@dhasani23
Copy link
Contributor Author

Note to self: try setting disabled: false on the button

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants