fix(inline-suggestion): replace vscode.cancellation with waitUntil for timeout #6256
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
related issue: #6079, #6252
caller
After investigation, it looks like mix use of
vscode.CancellationToken
andwaitUntil()
will likely cause cancellation token to be cancelled prematurely (might be because another layer of waitUntil will run the fetchOpenTabsContext asynchronously thus causing it to timeout prematurely) thereforefetchOpebtabsContext(..)
will return null in this case and hence causing test cases failing.Therefore, the issue here is actually not the test case itself and they're failing due to race condition
Solution
remove usage of cancellation token and only use waitUntil for timeout purpose
Functional testing
retrieved sup context as expected
Case 1: repomap is available (there are local imports)
Case 2: No repomap, should fallback to opentabs only
feature/x
branches will not be squash-merged at release time.License: I confirm that my contribution is made under the terms of the Apache 2.0 license.