test(amazonq): skip flaky crossfileContextUtil.test #6085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hweinstock
reviewed
Nov 21, 2024
| @@ -35,7 +35,7 @@ describe('crossFileContextUtil', function () { | |||
| sinon.restore() | |||
| }) | |||
|
|
|||
| describe('fetchSupplementalContextForSrc', function () { | |||
| describe.skip('fetchSupplementalContextForSrc', function () { | |||
There was a problem hiding this comment.
I've only seen the for t1 group, should return repomap + opentabs context one fail. Is there a reason we want to skip the other two in this block?
There was a problem hiding this comment.
um, i just think the t1 test are pretty much the same as t2 test, so it's still unclear to me why one fails but the other doesn't.
However let's skip t1 test only for now and skip others when we observe other failure, also it could help me narrow down where it likely went wrong.
jpinkney-aws
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#6079
Solution
Ignore the flaky test cases for now until we root caused why it failed occasionally in some CI machines
License: I confirm that my contribution is made under the terms of the Apache 2.0 license.