-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps(sdk): barebones general public client builder. #5940
Conversation
Output: string | ||
InstanceId: string | ||
} | ||
|
||
export class Ec2Client { | ||
export class Ec2Wrapper { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity what was the idea between calling it Ec2Wrapper? Is it because it's a toolkit wrapper around the sdk v3 builder?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah it seems like a more fitting name, and also because the EC2 v3 exports its client as EC2Client
(instead of EC2
as in v2) so want to avoid confusion between the names. Do you think that renaming the 'clients' to 'wrappers' as we migrate them makes sense?
/retryBuilds |
This PR is too large, and I am unable to resolve build problems. Moving to #6097 |
Problem
Start the transition to sdkv3. This PR is just a start, and is intended to serve as an opportunity to look at the design before building on it more. This is still missing a lot of features (see future work).
Excessive line changes are due to package-lock.json changes from install sdk-v3 clients.
Solution
Future Work
License: I confirm that my contribution is made under the terms of the Apache 2.0 license.