Fix JSR310 serialization error when preparing login panel #5216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a user is somehow in the situtation where they have an `sso-session` defined, with a token in their SSO cache (either valid/invalid), then prepareBrowser fails since it tries to serialize the state of `connectionSettings` without the jackson-jsr310 module. This is not intended behavior, so fix by configuring this to be an ignored field.
zixlin7
approved these changes
Dec 20, 2024
samgst-amazon
approved these changes
Dec 20, 2024
Qodana Community for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user is somehow in the situtation where they have an
sso-sessiondefined, with a token in their SSO cache (either valid/invalid), then prepareBrowser fails since it tries to serialize the state ofconnectionSettingswithout the jackson-jsr310 module.When using the IDE normally, this should not be possible because logout destroys the existing token and there is a prior check to see if user should be shown the chat panel / re-auth flow instead of the login browser
This is not intended behavior, so fix by configuring this to be an ignored field.
#5214
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.