Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

telemetry(amazonq): sending metric data in onCodeGeneration #5205

Merged
merged 5 commits into from
Dec 24, 2024

Conversation

siakmun-aws
Copy link
Contributor

@siakmun-aws siakmun-aws commented Dec 13, 2024

Problem

This is a part of the task to implement client side alarms in order to track success rate for the client.

Solution

  • Emit metric data telemetry on success/failure.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@siakmun-aws siakmun-aws force-pushed the siakmun/send-telemetry branch from 9d67f10 to ae717b6 Compare December 17, 2024 22:42
@siakmun-aws siakmun-aws marked this pull request as ready for review December 18, 2024 00:24
@siakmun-aws siakmun-aws requested a review from a team as a code owner December 18, 2024 00:24
@siakmun-aws siakmun-aws force-pushed the siakmun/send-telemetry branch from bf59888 to 3170ff8 Compare December 18, 2024 00:24
@siakmun-aws siakmun-aws force-pushed the siakmun/send-telemetry branch from 9078467 to 0a3901b Compare December 18, 2024 22:08
@siakmun-aws siakmun-aws changed the title feat(amazonq): sending metric data in onCodeGeneration telemetry(amazonq): sending metric data in onCodeGeneration Dec 18, 2024
@siakmun-aws siakmun-aws requested a review from rli December 18, 2024 22:31
@siakmun-aws siakmun-aws force-pushed the siakmun/send-telemetry branch 2 times, most recently from faf92d1 to 16a82ac Compare December 20, 2024 20:22
@siakmun-aws siakmun-aws force-pushed the siakmun/send-telemetry branch from 16a82ac to 7eb1221 Compare December 23, 2024 21:00
@siakmun-aws siakmun-aws merged commit 3e44279 into aws:main Dec 24, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants