Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

telemetry(amazonq): remove amazonq_utgGenerateTests metric override #5197

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

telemetry(amazonq): remove amazonq_utgGenerateTests metric override #5197

wants to merge 1 commit into from

Conversation

chungjac
Copy link

@chungjac chungjac commented Dec 11, 2024 •
edited
Loading

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

  • amazonq_utgGenerateTests metric has been moved to aws-toolkit-common so we can remove this metric and its types from aws-toolkit-jetbrains

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@chungjac chungjac requested a review from a team as a code owner December 11, 2024 22:34
laileni-aws
laileni-aws approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@laileni-aws laileni-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!
Did you test this and checked with Kibana?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laileni-aws laileni-aws laileni-aws approved these changes

@rli rli rli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chungjac @rli @laileni-aws