Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: force reauth when client registration is not found in cache #5102

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

samgst-amazon
Copy link
Contributor

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

Invalidate SSO tokens when client registration file is missing during refresh

  • Added specific handling for missing client registration file during token refresh
  • Introduced ClientRegistrationNotFoundException to distinguish between file-not-found and other failure cases
  • Forces re-authentication by invalidating tokens when registration file cannot be found
  • Leaves telemetry reporting for refresh flow intact

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@samgst-amazon samgst-amazon requested a review from a team as a code owner November 18, 2024 21:23
Copy link

github-actions bot commented Nov 18, 2024

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@rli
Copy link
Contributor

rli commented Nov 19, 2024

can we get some tests?

@samgst-amazon samgst-amazon marked this pull request as draft December 2, 2024 19:58
@samgst-amazon samgst-amazon marked this pull request as ready for review December 12, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants