Session retains credentials when disk full #5056
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rli
reviewed
Nov 6, 2024
...re/jetbrains-community/src/software/aws/toolkits/jetbrains/core/credentials/sso/DiskCache.kt
Outdated
Show resolved
Hide resolved
...re/jetbrains-community/src/software/aws/toolkits/jetbrains/core/credentials/sso/DiskCache.kt
Outdated
Show resolved
Hide resolved
Qodana Community for JVM2 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
rli
reviewed
Nov 7, 2024
| clientRegistrationCache(ssoRegion).tryDeleteIfExists() | ||
| } | ||
|
|
||
| override fun loadClientRegistration(cacheKey: ClientRegistrationCacheKey): ClientRegistration? { | ||
| LOG.debug { "loadClientRegistration for $cacheKey" } | ||
| val inputStream = clientRegistrationCache(cacheKey).tryInputStreamIfExists() | ||
| val cacheFile = clientRegistrationCache(cacheKey) | ||
| // try InMemoryCacheFirst in case of stale registration on full disk |
There was a problem hiding this comment.
shouldn't the disk be the source of truth?
consider the case where multiple different JetBrains IDE instances are running
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Implemented an in-memory caching mechanism as a fallback when disk space is full
-Add InMemoryCache object to store credentials as ByteArrays
-Update writeKey to store data in memory if disk write fails due to space constraints
-Modify load functions to check in-memory cache is file read fails
-Maintain existing error handling and telemetry patterns
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.