Update authentication logic to handle network issues #5010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qodana Community for JVM2 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...tbrains-community/src/software/aws/toolkits/jetbrains/core/credentials/ToolkitAuthManager.kt
Fixed
Show fixed
Hide fixed
...tbrains-community/src/software/aws/toolkits/jetbrains/core/credentials/ToolkitAuthManager.kt
Fixed
Show fixed
Hide fixed
...tbrains-community/src/software/aws/toolkits/jetbrains/core/credentials/ToolkitAuthManager.kt
Fixed
Show fixed
Hide fixed
...tbrains-community/src/software/aws/toolkits/jetbrains/core/credentials/ToolkitAuthManager.kt
Fixed
Show fixed
Hide fixed
...tbrains-community/src/software/aws/toolkits/jetbrains/core/credentials/ToolkitAuthManager.kt
Fixed
Show fixed
Hide fixed
...tbrains-community/src/software/aws/toolkits/jetbrains/core/credentials/ToolkitAuthManager.kt
Fixed
Show fixed
Hide fixed
samgst-amazon
force-pushed
the
samgst/UserFacingNetworkErrors
branch
from
e4d55ff to
f255e8b
Compare
manodnyab
reviewed
Oct 31, 2024
plugins/core/resources/resources/software/aws/toolkits/resources/MessagesBundle.properties
Outdated
Show resolved
Hide resolved
...tbrains-community/src/software/aws/toolkits/jetbrains/core/credentials/ToolkitAuthManager.kt
Outdated
Show resolved
Hide resolved
…es/MessagesBundle.properties Co-authored-by: manodnyab <[email protected]>
…orkErrors Merge remote-tracking branch 'origin/main' into samgst/UserFacingNetworkErrors
…oolkit-jetbrains into samgst/UserFacingNetworkErrors pull reviewed changes
rli
reviewed
Oct 31, 2024
...tbrains-community/src/software/aws/toolkits/jetbrains/core/credentials/ToolkitAuthManager.kt
Outdated
Show resolved
Hide resolved
...tbrains-community/src/software/aws/toolkits/jetbrains/core/credentials/ToolkitAuthManager.kt
Fixed
Show fixed
Hide fixed
rli
reviewed
Nov 1, 2024
...ins-community/tst/software/aws/toolkits/jetbrains/core/credentials/ToolkitAuthManagerTest.kt
Outdated
Show resolved
Hide resolved
...ins-community/tst/software/aws/toolkits/jetbrains/core/credentials/ToolkitAuthManagerTest.kt
Outdated
Show resolved
Hide resolved
...ins-community/tst/software/aws/toolkits/jetbrains/core/credentials/ToolkitAuthManagerTest.kt
Outdated
Show resolved
Hide resolved
...ins-community/tst/software/aws/toolkits/jetbrains/core/credentials/ToolkitAuthManagerTest.kt
Outdated
Show resolved
Hide resolved
...tbrains-community/src/software/aws/toolkits/jetbrains/core/credentials/ToolkitAuthManager.kt
Outdated
Show resolved
Hide resolved
...tbrains-community/src/software/aws/toolkits/jetbrains/core/credentials/ToolkitAuthManager.kt
Outdated
Show resolved
Hide resolved
...tbrains-community/src/software/aws/toolkits/jetbrains/core/credentials/ToolkitAuthManager.kt
Fixed
Show fixed
Hide fixed
...tbrains-community/src/software/aws/toolkits/jetbrains/core/credentials/ToolkitAuthManager.kt
Fixed
Show fixed
Hide fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Ensure user is not prompted to reauthorize when there are any network errors that cause failure while refreshing tokens, and the token is not expired. Network errors are currently defined as errors containing UnknownHostException or Unable to execute HTTP request:
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.