Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for DynamoDBEntryConversion #3586

Merged

Conversation

Dreamescaper
Copy link
Contributor

Description

As discussed with @normj , submitting tests for DynamoDBEntryConversion separetely from PR #3300 .

Motivation and Context

Increase unit tests coverage.
I've added tests for conversion from and to DynamoDbEntry for both V1 and V2, for Primitives, Collections, Dictionaries.

Types of changes

Tests only, no functional changes.

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed

License

  • I confirm that this pull request can be released under the Apache 2 license

Copy link
Member

@normj normj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for extra test coverage.

@Dreamescaper Dreamescaper force-pushed the add_tests_for_dynamodbentryconversion branch from 81169f0 to c87701f Compare December 20, 2024 22:13
@normj normj merged commit e2ace61 into aws:v4-development Dec 20, 2024
@normj
Copy link
Member

normj commented Dec 20, 2024

Merged, thanks again.

@Dreamescaper Dreamescaper deleted the add_tests_for_dynamodbentryconversion branch December 22, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants