Use ArrayPoolBufferWriter for Utf8JsonWriter for marshalling #3579
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the marshalling logic so that the
Utf8JsonWriter
uses anArrayPoolBufferWriter
for writing json. Since we cannot take a dependency on CommunityToolkit.HighPerformanceI backported the relevant code and added it to
ThirdParty.RuntimeBackports
with some very minor adjustments so that it compiles.Overall, I saw pretty huge improvements in terms of allocations and speed. Compared to the head of V4, depending on the payload size the speed improvement was anywhere from 5.7x to 12.62x faster with allocations decreasing by 3-4x.
These numbers are only for marshall/unmarshall time, not the network call
Motivation and Context
Testing
All Protocol Tests pass
Dry run will be done on the feature branch as a whole
Did some manual spot checking
Screenshots (if appropriate)
Types of changes
Checklist
License