Generator implementation for V2 smoke tests for C2J files. #3578
Conversation
| } | ||
| catch (Amazon<#=this.Config.ClassName#>Exception ex) | ||
| { | ||
| Assert.AreEqual("<#=errorId#>", ex.ErrorCode); |
There was a problem hiding this comment.
When I run this locally I get an exception because the <#= doesn't handle errorId being null. You need to add a null check before adding the Assert.AreEqual.
| } | ||
| } | ||
| #> | ||
| public async Task <#=testCase["id"]?.ToString() ?? "Test"#>() |
There was a problem hiding this comment.
Were there tests without an id field? Seems like a field that would be required.
| if (value.IsString) | ||
| { | ||
| #> | ||
| request.<#=key#> = "<#=value.ToString()#>"; |
There was a problem hiding this comment.
There are going to be times that the key defined in the smoke json file do not match exactly to the property name on the request. We change the case to match .NET conventions and sometimes have customizations to rename it. Look at how I wrote the FindOperation method that looks in the ServiceModel to find the shape by the model name versus the .NET name.
| } | ||
| else | ||
| { | ||
| var arrayValues = new List<string>(); |
There was a problem hiding this comment.
Can't remember in the SEP can there be arrays of more then just strings.
| @@ -8,6 +8,7 @@ | |||
| AddLicenseHeader(); | |||
| #> | |||
| using System; | |||
| using System.Collections.Generic; | |||
| using System.Threading.Tasks; | |||
| using Microsoft.VisualStudio.TestTools.UnitTesting; | |||
There was a problem hiding this comment.
(I'm not reviewing the PR, but...) Is there a reason why you're using MSTest as the test framework?
The hand-written files we have right now use xUnit (meaning they can run in parallel) and using xUnit will allow you to test your PR without making any changes to our build system (as long as they're found by the projects in this folder: https://github.com/aws/aws-sdk-net/tree/v4-development/sdk/test/SmokeTests).
Description
Implements the generator for smoke tests v2 format based on the new smoke-2.json schema. Key features:
Questions for review:
Motivation and Context
This implementation supports the new smoke tests format (smoke-2.json) which provides more configuration options and better structure for test cases. The generator creates test files that:
Testing
Types of changes
Checklist
License