Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DynamoDbv2 bug for incorrect DateTime epoch serialization when date falls out of epoch supported range #3442

Open
wants to merge 3 commits into
base: main-staging
Choose a base branch
from
Open

Fix DynamoDbv2 bug for incorrect DateTime epoch serialization when date falls out of epoch supported range #3442

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4b4407d
Use Long instead of int for epoch
sander1095 Aug 15, 2024
60c7190
Update AWSSDKUtils to return a long instead of int
sander1095 Aug 15, 2024
f9eac89
Use int64 -> string method and reset the code for the int method
sander1095 Aug 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions sdk/src/Services/DynamoDBv2/Custom/DocumentModel/Document.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,11 +254,11 @@ internal static DynamoDBEntry EpochSecondsToDateTime(DynamoDBEntry entry, string
// Converts a user-supplied DateTime-convertible DynamoDBEntry to epoch seconds stored in a Numeric Primitive.
internal static DynamoDBEntry DateTimeToEpochSeconds(DynamoDBEntry entry, string attributeName)
{
int? epochSeconds = null;
string epochSecondsAsString = null;
try
{
var dateTime = entry.AsDateTime();
epochSeconds = AWSSDKUtils.ConvertToUnixEpochSeconds(dateTime);
epochSecondsAsString = AWSSDKUtils.ConvertToUnixEpochSecondsString(dateTime);
}
catch (Exception e)
{
Expand All @@ -268,9 +268,9 @@ internal static DynamoDBEntry DateTimeToEpochSeconds(DynamoDBEntry entry, string
attributeName, entry, e);
}

if (epochSeconds.HasValue)
if (epochSecondsAsString != null)
{
entry = (Primitive)(epochSeconds.Value);
entry = new Primitive(epochSecondsAsString, saveAsNumeric: true);
}

return entry;
Expand Down