Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate DynamoDBOperationConfig Into Operation-Specific Configs #3421

Merged
merged 8 commits into from
Aug 9, 2024

Conversation

ashovlin
Copy link
Member

@ashovlin ashovlin commented Aug 5, 2024

Description

Merging the feature branch into v4-development. This combines #3380, #3387 , #3383, and #3376

Motivation and Context

#1748 - DynamoDBOperationConfig is shared amongst the object-persistence methods, but has become overloaded over time, with some properties only applying to some operations.

This moves us towards new, operation-specific config objects. We've marked methods that take DynamoDBOperationConfig as deprecated in V4, but are not planning to remove them entirely yet. We may do so in a future major version.

See the description of #3376 for a longer explanation of which properties are relevant to which operations.

Testing

PENDING DRY-RUN

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed

License

  • I confirm that this pull request can be released under the Apache 2 license

@ashovlin ashovlin changed the title Feature/v4 ddb separate config Separate DynamoDBOperationConfig Into Operation-Specific Configs Aug 5, 2024
@ashovlin ashovlin added the v4 label Aug 5, 2024
@ashovlin ashovlin requested review from 96malhar, normj and philasmar and removed request for 96malhar August 6, 2024 16:42
@96malhar
Copy link
Contributor

96malhar commented Aug 6, 2024

@ashovlin Can you rebase your PR and address the merge conflicts? I imagine the sooner this is done the better it is since new stuff is constantly being merged in v4-development

@ashovlin ashovlin force-pushed the feature/v4-ddb-separate-config branch from ad8c25d to e717814 Compare August 7, 2024 19:12
@ashovlin ashovlin force-pushed the feature/v4-ddb-separate-config branch from 942d23e to 181e595 Compare August 8, 2024 19:36
@ashovlin
Copy link
Member Author

ashovlin commented Aug 9, 2024

Rebased on current v4-development, and dry run 9fa7b1ed-5a5d-4a0e-86b5-5e5521b2525e passed.

@ashovlin ashovlin merged commit c4e2519 into v4-development Aug 9, 2024
1 check passed
@ashovlin ashovlin deleted the feature/v4-ddb-separate-config branch August 9, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants