-
Notifications
You must be signed in to change notification settings - Fork 862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate DynamoDBOperationConfig Into Operation-Specific Configs #3421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashovlin
changed the title
Feature/v4 ddb separate config
Separate DynamoDBOperationConfig Into Operation-Specific Configs
Aug 5, 2024
10 tasks
1 task
96malhar
approved these changes
Aug 6, 2024
@ashovlin Can you rebase your PR and address the merge conflicts? I imagine the sooner this is done the better it is since new stuff is constantly being merged in |
ashovlin
force-pushed
the
feature/v4-ddb-separate-config
branch
from
August 7, 2024 19:12
ad8c25d
to
e717814
Compare
normj
approved these changes
Aug 8, 2024
ashovlin
force-pushed
the
feature/v4-ddb-separate-config
branch
from
August 8, 2024 19:36
942d23e
to
181e595
Compare
Rebased on current |
This was referenced Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merging the feature branch into
v4-development
. This combines #3380, #3387 , #3383, and #3376Motivation and Context
#1748 -
DynamoDBOperationConfig
is shared amongst the object-persistence methods, but has become overloaded over time, with some properties only applying to some operations.This moves us towards new, operation-specific config objects. We've marked methods that take
DynamoDBOperationConfig
as deprecated in V4, but are not planning to remove them entirely yet. We may do so in a future major version.See the description of #3376 for a longer explanation of which properties are relevant to which operations.
Testing
PENDING DRY-RUN
Types of changes
Checklist
License