Add stale time config to InstanceProfileCredentialsProvider #5758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for refreshing credentials earlier due to stale value. This will help prevent returning invalid credentials when an error is encountered during asynchronous refresh.
…for refreshing credentials earlier due to stale value. This will help prevent returning invalid credentials when an error is encountered during asynchronous refresh.
|
zoewangg
reviewed
Dec 18, 2024
Comment on lines
+63
to
+65
| public ResourcesEndpointRetryPolicy retryPolicy() { | ||
| return new ContainerCredentialsRetryPolicy(); | ||
| } |
There was a problem hiding this comment.
I don't think we can add retry at this point for IMDS credentials provider because it may increase latency and break customers.
There was a problem hiding this comment.
right, that was a ask from Hadoop. Instead we can add it as an optional config as well
joviegas
reviewed
Dec 19, 2024
| @@ -174,7 +178,7 @@ private Instant staleTime(Instant expiration) { | |||
| return null; | |||
| } | |||
|
|
|||
| return expiration.minusSeconds(1); | |||
| return expiration.minus(staleTime); | |||
There was a problem hiding this comment.
I was trying to understand comment in #3314 (comment)
Looks like the 1 sec is intentional , if a user configures an excessively large stale time (e.g., expiration.minusMinutes(10)), credentials might be marked as stale too early, causing unnecessary refreshes and increased load on the credential provider. WDYT ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add stale time config to
InstanceProfileCredentialsProviderto allow for refreshing credentials earlier due to stale value. This will help prevent returning invalid credentials when an error is encountered during asynchronous refresh.Motivation and Context
Fixes for #5247 , this will allow user to provide a higher value for prefetch to prevent returning expired credentails without changing default value. Increasing this value may lead to a higher rate of request to IMDS, so we ought to avoid changing the base default value for it.
Modifications
staleTimeconfiguration option toInstanceProfileCredentialsProviderInstanceProfileCredentialsProviderTesting
Added unit tests
Screenshots (if appropriate)
Types of changes